Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses T and F argument types, to Racket values
#tand#frespectively. T and F are already emitted byosc-element->byteswhen given booleans, but without this patch,bytes->osc-elementwill throwunimplemented type char: 84(for T) andunimplemented type char: 70(for F) when given an OSC message containing booleans.Did I handle the
offsetparameter correctly? The spec says "No bytes are allocated in the argument data" for these types. It seems to work correctly - I also tested putting booleans in a bundle, and that seemed to parse correctly too.For the tests, I tried to align the address and message sizes to 4 bytes, and they pass, but I'm also not super confident I padded it correctly.