Skip to content

v0.8.0 development branch - #294

Open
jbaublitz wants to merge 5 commits into
mainfrom
0.8.0-dev
Open

v0.8.0 development branch#294
jbaublitz wants to merge 5 commits into
mainfrom
0.8.0-dev

Conversation

@jbaublitz

@jbaublitz jbaublitz commented Jul 23, 2025

Copy link
Copy Markdown
Owner

Closes #318

@jbaublitz jbaublitz added this to the neli-0.8.0 milestone Jul 23, 2025
@jbaublitz jbaublitz self-assigned this Jul 23, 2025
@jbaublitz
jbaublitz force-pushed the 0.8.0-dev branch 2 times, most recently from c489ee1 to f5c679c Compare January 28, 2026 14:56
jbaublitz and others added 5 commits March 3, 2026 16:14
Add null termination checking for str's FromBytesWithInputBorrowed
implementation. The check also ensures there's no interior null bytes
in the string.

While here change to use more safe pattern for indexing the underlying
slice.

With this change it's now possible to implement String's
FromBytesWithInput by reading str first and then making it owned
reducing code duplication.
…entation

And then use &[u8] FromBytesWithInputBorrowed in str's
FromBytesWithInputBorrowed.
@jbaublitz

Copy link
Copy Markdown
Owner Author

Fix clippy error here:

error: the `Err`-variant returned from this closure is very large
   --> src/rtnl.rs:595:35
    |
595 |               .try_fold(Vec::new(), |mut v, m| {
    |  ___________________________________^
596 | |                 v.push(m?);
597 | |                 Result::<_, RouterError<Rtm, Ifinfomsg>>::Ok(v)
598 | |             })
    | |_____________^
    |
   ::: src/err.rs:385:5
    |
385 |       BadSeqOrPid(Nlmsghdr<T, P>),
    |       --------------------------- the largest variant contains at least 128 bytes
    |
    = help: try reducing the size of `err::RouterError<consts::rtnl::Rtm, rtnl::Ifinfomsg>`, for example by boxing large elements or replacing it with `Box<err::RouterError<consts::rtnl::Rtm, rtnl::Ifinfomsg>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#result_large_err
    = note: `-D clippy::result-large-err` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::result_large_err)]`

error: could not compile `neli` (lib test) due to 1 previous error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Rust editions

2 participants