Combine efforts to fix CI: #2181 + #2183 #2184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`click` v8.2 needs to be handled -- as a follow-up change -- but it's hard to know if the application itself will work with it yet. Instead of restricting that in tox.ini, I have chosen to restrict it in the metadata itself. `setuptools` on newer versions breaks some of the tests, but restricting it for package metadata is definitely wrong. Therefore, it is only restricted for now on the `pipsupported` build. This should lead to improved CI, but will not result in all tests passing.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
The stderr may stop after noting the missing version, without mentioning the missing name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cherry-picked a commit from #2183 onto #2181 to produce what I believe is the truly minimal changeset in order to get CI working correctly.
I've done a lot of reading of the past few days to figure out what all needs to be done, and I think most or even all of #2183 will be good to apply.
But right now, it forces a reviewer to reckon with several different topics at once, plus it has a test skip which we need to work around.
I'd like us to get this fix completed in as minimal a manner as possible so that we can take changes like 64606f4 and have clear focus when we look at them.
Right now, Python 3.12 isn't being tested in CI, nor is "piplatest" (from tox config)1, so there's a lot of CI cleanup ground to cover.
Healing the currently configured CI matrix takes priority.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.Footnotes
We don't want to block PRs on
piplatest, so this is intentional. But it would be good to get that cron CI job working again. ↩