feat: add SHA-256 integrity verification for C++ and Python paths#12
Open
yuliuyi717-ux wants to merge 1 commit intojavelin-anticheat:mainfrom
Open
Conversation
2 tasks
Author
|
Hey folks, gentle bump on #12 (SHA-256 integrity verification for both C++ and Python paths). It’s been open for a few days, and I’d really appreciate a review when you have time. Happy to update anything needed—thanks! |
Author
|
Quick follow-up on #12. The SHA-256 integrity verification updates for both C++ and Python paths are in place. If you want any adjustment to fit project conventions, I can update quickly. Appreciate a review when you have time. |
Author
|
Hi maintainers, just a gentle follow-up on this PR adding SHA-256 integrity verification for both the C++ and Python paths. When you have a moment, could you please take a look and share any feedback? Happy to make any updates needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #4
This implements integrity verification for both paths described in #4.
What changed:
AntiCheat.cpp)JAVELIN_EXPECTED_CRC32)JAVELIN_EXPECTED_SHA256)anti_cheat.py)JAVELIN_EXPECTED_SHA256README.md)tests/test_integrity.py)Validation run:
python3 -m unittest discover -s tests -p "test_*.py"python3 -m py_compile anti_cheat.pyNote:
bcryptAPI), but C++ runtime validation was not executed in this macOS environment.