Add Java 11 Nestmate support to java.lang.Class model #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented getNestHost() and isNestmateOf() in Class.java model. - Added NestmateTest.java to verify behavior for top-level and inner classes. - Enables JPF to support modern Java nest-based access control checks.
Contributor
Author
|
Hi @cyrille-artho, following your advice to focus on functionality rather than test optimization, I've submitted a PR adding Java 11 Nestmate support ( I included a new unit test to verify the behavior for both top-level and inner classes. Ready for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented missing Java 11 Nestmate access control methods in the
java.lang.Classmodel. This allows JPF to execute code that relies ongetNestHost()andisNestmateOf(), which are increasingly common in modern Java libraries.Changes
src/classes/modules/java.base/java/lang/Class.javagetNestHost(): TraversinggetEnclosingClass()to find the nest host (top-level class).isNestmateOf(Class): Compares nest hosts of two classes.src/tests/gov/nasa/jpf/test/java/lang/NestmateTest.javaTesting
NestmateTest.javapassesRelation to Issues
Partial fix for general "Missing Methods in Class" issues (like #235), specifically targeting Java 11 support.