Simplify rFunctionExistsInModule source-module branch#81
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the source-file sourcing approach in rFunctionExistsInModule()'s source-module branch with a namespace lookup via utils::getFromNamespace(), wrapped in a small function_exists() helper. This avoids parsing/evaluating every .R file in the module on each call (~10x speedup locally).
Changes:
- Adds
function_exists()helper that wrapsutils::getFromNamespace()intryCatchto return TRUE/FALSE. - Rewrites the source-module branch of
rFunctionExistsInModule()to callfunction_exists(moduleName, funName)instead of sourcing allR/*.Rfiles into a temp env.
vandenman
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source-module (
else) branch ofrFunctionExistsInModulesourced every.Rfile in the module'sR/directory into a temporary environment on eachcall, just to check whether one function is defined.
This replaces it with a namespace lookup via
getFromNamespace, wrapped toreturn TRUE/FALSE. Per-call resolution dropped ~10x locally (≈0.23s → ≈0.02s)
and avoids repeatedly parsing/evaluating module source.