[jaspTTests] Add grouping variable label and Student's/Welch's distinction...#387
Open
sisyphus-jasp wants to merge 1 commit into
Open
[jaspTTests] Add grouping variable label and Student's/Welch's distinction...#387sisyphus-jasp wants to merge 1 commit into
sisyphus-jasp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: jasp-stats/jasp-issues#3946
Root cause
Independent-samples output missed two metadata bits:
Groupheader, never included selected grouping variable.What changed
Edited
R/ttestindependentsamples.Ronly:.ttestIndependentMainTable, added footnote when both Student and Welch are requested: Student assumes equal variances, Welch does not..ttestIndependentDescriptivesTable, changed group column header fromGrouptoGroup (<group variable>)viagettextf().Caveats / reviewer checks
.jaspruns in headless tests, group variable may show encoded name (jaspColumnX). In Desktop UI this should map through normal display path.Implementation Plan
Root cause
R/ttestindependentsamples.R(.ttestIndependentDescriptivesTable), group column title hardcoded togettext("Group"); selected grouping variable label/name not shown..ttestIndependentMainTable, Student/Welch notes only exist in single-test (onlyTest) branch. With both enabled, table has both rows but no footnote clarifying difference.Proposed changes
.ttestIndependentDescriptivesTable, compute group column title with grouping variable (gettextf("Group (%s)", options[["group"]])) and use it inaddColumnInfo()..ttestIndependentMainTable, when bothwantsStudentsandwantsWelchsare TRUE, add one footnote clarifying Student assumes equal variances and Welch does not.R/ttestindependentsamples.R.Expected test impact
testAll()should pass unless expectations encode old metadata; then statusNEEDS_TEST_UPDATE.Add grouping variable label and Student's/Welch's distinction footnotes to independent samples t-test output
Attachment Descriptions
The following images were attached to the issue. They have been converted to text descriptions — the original image files are NOT available in the workspace. Do not reference screenshot filenames in your output.
Image
The screenshot shows JASP output for a T-Tests analysis, specifically an Independent Samples T-Test.
A Descriptives section is visible below:
No error trace or call stack is visible in the screenshot.
No analysis-option panel (checkboxes/dropdowns/radio buttons) is shown, so selected settings cannot be directly confirmed beyond what is implied by the displayed Student and Welch test outputs and the grouped descriptives table.
Test Results
Automated Code Review
Approved after 1 review iteration(s).