Skip to content

Improve user experience for plot editing. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vandenman wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Improve user experience for plot editing. #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions R/plotEditing.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,12 @@ optionsDiff <- function(new, old) {
#' @title Edit a plot
#' @param graph a ggplot2 object
#' @param newOptions an options list
#' @param ggbuild optionally a pre-computed ggplot_built object (avoids a
#' second call to \code{ggplot_build()} when the caller already built the
#' plot).
#'
#' @export
plotEditing <- function(graph, newOptions) {
plotEditing <- function(graph, newOptions, ggbuild = NULL) {

if (!is_ggplot(graph))
stop2("graph should be a ggplot2")
Expand All @@ -81,7 +84,8 @@ plotEditing <- function(graph, newOptions) {
}
}

ggbuild <- ggplot_build(graph)
if (is.null(ggbuild))
ggbuild <- ggplot_build(graph)
# TODO: first check if plot was previously edited, if so use those options
oldOptions <- plotEditingOptions(ggbuild)
validateOptions(newOptions, oldOptions)
Expand Down
Loading