Skip to content

Improve user experience for plot editing.#205

Open
vandenman wants to merge 1 commit into
jasp-stats:masterfrom
vandenman:faster_editing
Open

Improve user experience for plot editing.#205
vandenman wants to merge 1 commit into
jasp-stats:masterfrom
vandenman:faster_editing

Conversation

@vandenman
Copy link
Copy Markdown
Contributor

@vandenman vandenman commented May 20, 2026

  1. Avoid saving the entire state during plot editing.
  2. One fewer ggplot_build call.

Requires jasp-stats/jaspGraphs#151 and will break otherwise.

@vandenman
Copy link
Copy Markdown
Contributor Author

@juliuspfadt not sure who to ask to review this so I gave you the honor, since you also managed to install and test another multi module PR 😅

To test this,

  1. Experience current plot editing speeds.
  2. Install both the jaspBase and jaspGraphs PR into say jaspDescriptives.
  3. Retry plot editing.

This should only affect the editing speed of the regular plots, not plotly.

@juliuspfadt
Copy link
Copy Markdown

score...

@juliuspfadt
Copy link
Copy Markdown

I cant find a speedup... I did this, although I am not sure anymore if those were the right steps:

renv::install(".", prompt = FALSE)
renv::install("vandenman/jaspBase@1db6d39256b2d212ae6307b0d20ea3dabba33b2e", type = "source", prompt = FALSE)
renv::install("vandenman/jaspGraphs@f9aee2d4f1fe6057514cf3873ed8100ca246e4f9", type = "source", prompt = FALSE)
jaspModuleTools::prepare_for_jasp_loading()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants