Skip to content

Edited sec in your first test #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Msuf123
Copy link

@Msuf123 Msuf123 commented Oct 3, 2024

I was struggling to understand spy function so i edited and made it a little more detailed so that beginner like me can understand.

@Msuf123
Copy link
Author

Msuf123 commented Oct 3, 2024

Let me know if there is any mistake in content that i wrote.

@Msuf123
Copy link
Author

Msuf123 commented Aug 1, 2025

Hey can someone view my pr and merge if they find useful

@sgravrock
Copy link
Member

I'm sorry for not responding to this much sooner. I try to respond to PRs promptly but I lost track of this one.

The biggest problem I see is that the new summary information in this PR isn't correct. It says "Spies function are never executed", but that depends on how both the individual spy and the default strategy are configured. It's common to do things like spyOn(someObj, 'methodName').and.callThrough() which does lead to the spied-on function being executed.

Some other issues I see:

  • The first three lines of added content in this PR are a duplicate of what's immediately above.
  • The new content refers to a setBar function and a bar variable that aren't defined anywhere.
  • There are a number of spelling, grammar, and spacing issues.

I don't mind cleaning up spelling, grammar, and spacing. But I think the content would have to be more or less completely rewritten to be accurate and to not depend on information (like what setBar and bar are) that the reader hasn't been shown yet. Providing just the right level of detail at the beginning of a tutorial like this is tricky, especially when describing something as flexible as spies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants