std: Remove `rand` crate and module by dvc94ch · Pull Request #158 · japaric/steed

dvc94ch · 2017-11-12T13:29:06Z

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

The allocator feature was removed in ralloc commit cd8d627ecd5eb633833fe9fb8973219c2101ff61. Closes japaric#153.

dvc94ch · 2017-11-17T14:20:36Z

This PR fixes building steed with a recent rust-src version.

japaric

Thanks, @dvc94ch. LGTM. I had a question about the Xargo.toml change though.

japaric · 2017-11-18T15:52:32Z

Xargo.toml


 [dependencies.compiler_builtins]
 features = ["mem"]
+git = "https://github.com/rust-lang-nursery/compiler-builtins"


why should we switch to the git version? rust-src contains a snapshot of that git repo. Is there some version mismatch problem?

I wasn't aware that compiler-builtins was distributed with rust-src. Should it be removed from the other Xargo.toml files too?

stupid question - I guess it makes sense for the Xargo.test.toml file since it there are a lot of "supported" platforms

collections and rand crates have been removed/replaced.

japaric · 2017-11-20T14:11:08Z

Actually, none of the Xargo.toml should specify compiler-builtins as a git repo.

japaric · 2017-11-20T14:12:39Z

That should work, I think.

@homunkulus r+

homunkulus · 2017-11-20T14:12:40Z

📌 Commit e56b319 has been approved by japaric

homunkulus · 2017-11-20T14:12:47Z

⌛ Testing commit e56b319 with merge fabd9c0...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2017-11-20T14:25:56Z

💔 Test failed - status-travis

homunkulus · 2017-11-30T10:46:45Z

⌛ Testing commit e56b319 with merge 42fde8f...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2017-11-30T10:47:59Z

💔 Test failed - status-travis

dvc94ch · 2017-12-04T06:48:32Z

Mmh error[E0463]: can't find crate for std``, I think I had this error too and then it magically disappeared. Any idea why it's trying to find a crate for std?

japaric · 2017-12-16T15:21:44Z

Any idea why it's trying to find a crate for std?

The rand crate from crates.io depends on std. I don't think we need rand to be a dev-dependency though. Removing it should fix the error, I think.

japaric · 2017-12-16T15:22:17Z

@homunkulus r+

homunkulus · 2017-12-16T15:22:18Z

📌 Commit 2e9830c has been approved by japaric

homunkulus · 2017-12-16T15:22:24Z

⌛ Testing commit 2e9830c with merge a887325...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2017-12-16T17:04:38Z

💔 Test failed - status-travis

japaric · 2017-12-18T09:16:10Z

Problems with the Xargo sysroot. Let's try again.

@homunkulus r+

homunkulus · 2017-12-18T09:16:11Z

📌 Commit 5883feb has been approved by japaric

homunkulus · 2017-12-18T09:16:17Z

⌛ Testing commit 5883feb with merge bb7c831...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2017-12-18T09:33:34Z

💔 Test failed - status-travis

homunkulus · 2018-01-12T20:46:26Z

⌛ Testing commit 5883feb with merge 0c28304...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2018-01-12T20:54:40Z

💔 Test failed - status-travis

homunkulus · 2018-01-13T16:10:24Z

⌛ Testing commit 5883feb with merge e5eed94...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2018-01-13T16:13:13Z

💔 Test failed - status-travis

homunkulus · 2018-01-23T20:10:47Z

⌛ Testing commit 5883feb with merge 61608e0...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2018-01-23T20:12:31Z

💔 Test failed - status-travis

homunkulus · 2018-01-24T19:48:18Z

⌛ Testing commit 5883feb with merge 08639da...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2018-01-24T19:51:52Z

💔 Test failed - status-travis

homunkulus · 2018-02-17T16:05:46Z

⌛ Testing commit 5883feb with merge aec06de...

std: Remove `rand` crate and module I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet. Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

homunkulus · 2018-02-17T16:06:25Z

💔 Test failed - status-travis

dvc94ch added 2 commits November 12, 2017 14:23

std: Remove rand crate and module

53342db

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

Fix ralloc build.

eeae245

The allocator feature was removed in ralloc commit cd8d627ecd5eb633833fe9fb8973219c2101ff61. Closes japaric#153.

japaric approved these changes Nov 18, 2017

View reviewed changes

Update xargo files.

c8316c0

collections and rand crates have been removed/replaced.

dvc94ch force-pushed the remove-rand branch from e7dbc06 to c8316c0 Compare November 20, 2017 08:26

japaric added 2 commits November 20, 2017 15:11

use the compiler-builtins source from the rust-src component

9d1b0da

use the compiler-builtins source from the rust-src component

e56b319

drop rand dev-dependency

2e9830c

blow the Xargo directory after changing the Xargo.toml file

5883feb

Conversation

dvc94ch commented Nov 12, 2017

Uh oh!

dvc94ch commented Nov 17, 2017

Uh oh!

japaric left a comment

Choose a reason for hiding this comment

Uh oh!

japaric Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

dvc94ch Nov 20, 2017

Choose a reason for hiding this comment

Uh oh!

dvc94ch Nov 20, 2017

Choose a reason for hiding this comment

Uh oh!

japaric commented Nov 20, 2017

Uh oh!

japaric commented Nov 20, 2017

Uh oh!

homunkulus commented Nov 20, 2017

Uh oh!

homunkulus commented Nov 20, 2017

Uh oh!

homunkulus commented Nov 20, 2017

Uh oh!

homunkulus commented Nov 30, 2017

Uh oh!

homunkulus commented Nov 30, 2017

Uh oh!

dvc94ch commented Dec 4, 2017

Uh oh!

japaric commented Dec 16, 2017

Uh oh!

japaric commented Dec 16, 2017

Uh oh!

homunkulus commented Dec 16, 2017

Uh oh!

homunkulus commented Dec 16, 2017

Uh oh!

homunkulus commented Dec 16, 2017

Uh oh!

japaric commented Dec 18, 2017

Uh oh!

homunkulus commented Dec 18, 2017

Uh oh!

homunkulus commented Dec 18, 2017

Uh oh!

homunkulus commented Dec 18, 2017

Uh oh!

homunkulus commented Jan 12, 2018

Uh oh!

homunkulus commented Jan 12, 2018

Uh oh!

homunkulus commented Jan 13, 2018

Uh oh!

homunkulus commented Jan 13, 2018

Uh oh!

homunkulus commented Jan 23, 2018

Uh oh!

homunkulus commented Jan 23, 2018

Uh oh!

homunkulus commented Jan 24, 2018

Uh oh!

homunkulus commented Jan 24, 2018

Uh oh!

homunkulus commented Feb 17, 2018

Uh oh!

homunkulus commented Feb 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants