fix: preserve transport base path when building REST polling URL#199
Merged
shivanshtalwar0 merged 3 commits intojanuscaler:masterfrom Mar 19, 2026
Merged
Conversation
shivanshtalwar0
requested changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes REST polling URL construction so janus_client no longer assumes a hardcoded /janus path.
The plugin now preserves the provided transport base endpoint path and appends only the session segment, enabling API Gateway / reverse proxy deployments with custom public paths.
Changes
Benefits
Testing
Breaking Changes
None — backward compatible.
Notes
API docs were not regenerated in this PR to keep review focused; a docs-only follow-up PR can be provided if needed.
Closes #198