-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: improve sidebar UI with distinct sections and better empty states #6745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
d52725f to
277215f
Compare
|
@louis-menlo, @urmauur |
257d9c4 to
49e8fc7
Compare
|
@urmauur . Can you review and merge this. |
d2e0226 to
79745f7
Compare
hey @github-roushan 👋 However, we’d prefer not to introduce background color differences between the Projects and Chats sections for now. We’d like to keep the sidebar’s unified background style. If you’re up for it, feel free to adjust the PR to keep the layout and logic changes but remove the new background colors (bg- Thanks again for helping make Jan better! 💪 |
Sure will make the changes |
05d5944 to
c0a966f
Compare
|
@urmauur Done. |
c0a966f to
cbe3358
Compare
|
Hey @louis-menlo, @urmauur. Just giving this a gentle nudge — I’ve made all the requested changes! Would love to get it merged before the merge conflicts decide to throw a party . |
36cc5ea to
3e0d536
Compare
- Add distinct backgrounds for Projects and Chats sections - Projects section now has darker background (bg-left-panel-fg/5) while Chats has ighter background (bg-left-panel-fg/3) - Add proper spacing and padding between sections - Fix empty state logic to show "No threads yet" when all threads are in projects
3e0d536 to
d8d3285
Compare
|
@Minh141120 . Can you please merge this |
|
Hi @github-roushan thank you for the contribution, but we reserve the right to decide when to merge or closed certain PR as it might not reflected well on our direction for the product. Please avoid pinging our member repeatedly moving forward. We always actively review each PR every release cycle, so there is no need to do this as it would be disturbing our member from the other more prioritized task they are working on. That being said, if you still feel strongly that the PR is needed, you can also fork our project and provide alternative to the users you are catering for. All good by us. |


Describe Your Changes
Fixes Issues
Self Checklist