Skip to content

Conversation

@github-roushan
Copy link
Contributor

@github-roushan github-roushan commented Oct 6, 2025

Describe Your Changes

  • Add distinct backgrounds for Projects and Chats sections
  • Add proper spacing and padding between sections
  • Fix empty state logic to show "No threads yet" when all threads are in projects

Fixes Issues

  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-roushan
Copy link
Contributor Author

@github-roushan
Copy link
Contributor Author

@github-roushan
Copy link
Contributor Author

@louis-menlo, @urmauur

@louis-jan louis-jan requested a review from urmauur October 6, 2025 13:30
@github-roushan github-roushan force-pushed the sidebar-improv branch 2 times, most recently from 257d9c4 to 49e8fc7 Compare October 7, 2025 08:38
@github-roushan
Copy link
Contributor Author

@urmauur . Can you review and merge this.

@github-roushan
Copy link
Contributor Author

@LazyYuuki

@urmauur
Copy link
Member

urmauur commented Oct 8, 2025

Screenshot 2025-10-08 at 13 11 05

hey @github-roushan 👋
Thanks for the PR really appreciate the improvements around section spacing, padding, and the empty-state logic 🙏

However, we’d prefer not to introduce background color differences between the Projects and Chats sections for now. We’d like to keep the sidebar’s unified background style.

If you’re up for it, feel free to adjust the PR to keep the layout and logic changes but remove the new background colors (bg-left-panel-fg/5 and bg-left-panel-fg/3). Otherwise, we can close this and revisit the styling direction later.

Thanks again for helping make Jan better! 💪

@github-roushan
Copy link
Contributor Author

Screenshot 2025-10-08 at 13 11 05 hey @github-roushan 👋 Thanks for the PR really appreciate the improvements around section spacing, padding, and the empty-state logic 🙏

However, we’d prefer not to introduce background color differences between the Projects and Chats sections for now. We’d like to keep the sidebar’s unified background style.

If you’re up for it, feel free to adjust the PR to keep the layout and logic changes but remove the new background colors (bg-left-panel-fg/5 and bg-left-panel-fg/3). Otherwise, we can close this and revisit the styling direction later.

Thanks again for helping make Jan better! 💪

Sure will make the changes

@github-roushan
Copy link
Contributor Author

@urmauur Done.

@github-roushan
Copy link
Contributor Author

Hey @louis-menlo, @urmauur. Just giving this a gentle nudge — I’ve made all the requested changes! Would love to get it merged before the merge conflicts decide to throw a party .

- Add distinct backgrounds for Projects and Chats sections
- Projects section now has darker background (bg-left-panel-fg/5) while Chats has ighter background (bg-left-panel-fg/3)
- Add proper spacing and padding between sections
- Fix empty state logic to show "No threads yet" when all threads are in projects
@github-roushan
Copy link
Contributor Author

github-roushan commented Oct 15, 2025

@Minh141120 . Can you please merge this

@LazyYuuki
Copy link
Contributor

Hi @github-roushan thank you for the contribution, but we reserve the right to decide when to merge or closed certain PR as it might not reflected well on our direction for the product.

Please avoid pinging our member repeatedly moving forward. We always actively review each PR every release cycle, so there is no need to do this as it would be disturbing our member from the other more prioritized task they are working on.

That being said, if you still feel strongly that the PR is needed, you can also fork our project and provide alternative to the users you are catering for. All good by us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants