Fix broken authorization caused by missing env#5
Open
WillTaylor22 wants to merge 1 commit intojameschambers:masterfrom
Open
Fix broken authorization caused by missing env#5WillTaylor22 wants to merge 1 commit intojameschambers:masterfrom
WillTaylor22 wants to merge 1 commit intojameschambers:masterfrom
Conversation
To reproduce:
rails _6.0.3.2_ new test-api --api -m boring-bits-rails-api/template.rb
$ rails c
> ENV["DEVISE_JWT_SECRET_KEY"]
=> nil
$ rspec
Failures:
...
1) Api::UsersController When fetching a user returns 200
Failure/Error: expect(response.status).to eq(200)
...
12 examples, 3 failures
Failed examples:
rspec ./spec/controllers/users_controller_spec.rb:15 # Api::UsersController When fetching a user returns 200
rspec ./spec/controllers/users_controller_spec.rb:19 # Api::UsersController When fetching a user returns the user
rspec ./spec/controllers/users_controller_spec.rb:33 # Api::UsersController When a user is missing returns 404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce:
rails 6.0.3.2 new test-api --api -m boring-bits-rails-api/template.rb
$ rails c
$ rspec
Failures:
...
Failure/Error: expect(response.status).to eq(200)
...
12 examples, 3 failures
Failed examples:
rspec ./spec/controllers/users_controller_spec.rb:15 # Api::UsersController When fetching a user returns 200
rspec ./spec/controllers/users_controller_spec.rb:19 # Api::UsersController When fetching a user returns the user
rspec ./spec/controllers/users_controller_spec.rb:33 # Api::UsersController When a user is missing returns 404