[Sheet] PopScope - fix onPopInvoked usage in preventPop

[Michae1Weiss]

Problem

The onPopInvoked method in Route is deprecated and no longer triggers pop handling, which prevents onPopInvokedWithResult in PopScope from being called. As a result, PopScope does not properly intercept back navigation when using SheetRoute and derived classes.

Before

Screencast.from.2025-02-01.14-15-22.webm

After

Screencast.from.2025-02-01.14-16-01.webm

Solution

Updated preventPop to call onPopInvokedWithResult instead of the deprecated onPopInvoked.

Changes

• Replaced route.onPopInvoked(false) with route.onPopInvokedWithResult(false, null) in preventPop.

Evidence

• Added a PopScope example to the project for future testing.

🚀

[orestesgaolin]

LGTM @jamesblasco

[orestesgaolin]

Thanks @Michae1Weiss for the contribution. Wondering if you have any thoughts on onPopPage being deprecated as well?

[Michae1Weiss]

Good point! I should test that as well. Thanks for the hint, @orestesgaolin . I'll take a closer look at it tomorrow.

[huynhmytuandev]

Is there any update on this?

[Michae1Weiss]

Is there any update on this?

Thanks for the reminder @huynhmytuandev ! I actually have a few days off this week, so I’ll finally do a deep dive into onPopPage and Co (as @orestesgaolin mentioned) and test some edge cases.
To make PopScope work properly, I’m currently using this in my pubspec.yaml:

  # The official package doesn’t yet include my pull request (`[Sheet] PopScope - ... #452`),
  # so until it's merged, I’m using my own fork to get the fix.
  # Once it's merged upstream, we can switch back to the official package.
  sheet:
    git:
      url: https://github.com/Michae1Weiss/modal_bottom_sheet.git 
      ref: main
      path: sheet/

If you don’t hear from me this week, feel free to poke me again — I’m a professional procrastinator