You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This enables projects that use Canard to update to the latest version of CanCanCan and handles deprecation warnings for Rails 6 that are resolved in v2.x
So it has to do with the version of SQLite3 that Rails 3.x wants vs. what's available. If I pin sqlite3 to ~> 1.3.5 in Gemfile, I can get tests to run, but with lots of deprecation warnings, a circular reference warning, and errors. I think much of this has to do with the old version of Rails, but I'll have to do more digging later on.
All the errors are around Mongo, which no one should be using anyway ;)
EDIT: this was because I don't have Mongo installed locally, so I pushed the modified version, which ran, and passed on Ruby builds for 2.2 - 2.4. Fails for Ruby < 2.2 and jRuby... (see details here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables projects that use Canard to update to the latest version of CanCanCan and handles deprecation warnings for Rails 6 that are resolved in v2.x