feat(rules): map and validate job export rows#4
Merged
Merged
Conversation
Add pure mapping, validation, and duplicate-handling rules for job export rows. Invalid rows are rejected before duplicate handling, and the first valid job_id wins. Tested: uv run pytest tests/test_mapping.py tests/test_validation.py tests/test_duplicate_handling.py -v Tested: uv run ruff check src/clean_data_export_api/mapping.py src/clean_data_export_api/validation.py tests Tested: uv run basedpyright Tested: uv run pytest tests/test_mapping.py tests/test_validation.py tests/test_duplicate_handling.py --cov=clean_data_export_api.mapping --cov=clean_data_export_api.validation --cov-report=term-missing Tested: uv run pytest -v Tested: uv run pytest --cov=clean_data_export_api --cov-report=term-missing --cov-fail-under=90 Tested: uv run python -m compileall src tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add the pure data rules needed before output writing and export orchestration.
Scope
Out of Scope
Modifications
Test Plan
Docs Impact
none
ADR Check
Result
The core job export rules are deterministic, testable, and independent from file output, persistence, API, and CLI code.