replace kwargs double backslash for multiline messages #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jadolg
requested changes
Mar 14, 2025
There was a problem hiding this comment.
Hi @leonbuchnerbd
thank you for your contribution.
I left you a comment here with some changes I think are worth doing and I think the linter isn't happy. That should be easy to fix with black.
|
|
i updated your change request. i hope that will works now. ty |
jadolg
requested changes
Sep 5, 2025
Comment on lines
+15
to
+17
| payload["channel"] = channel | ||
| if room_id: | ||
| payload["roomId"] = room_id |
There was a problem hiding this comment.
If both channel and roomId are not specified, this method should rise an exception
raise RocketMissingParamException("roomId or channel required")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocketchat_API/APISections/base.py line 86
if you want to use the api to send multiline messages, you have to adapt the kwargs arguments.
the kwargs arguments are json serialized and have problems with escape sequences.
I fixed this here.