fix(twitter): preserve text when posting images#1180
Open
hanzili wants to merge 1 commit intojackwener:mainfrom
Open
fix(twitter): preserve text when posting images#1180hanzili wants to merge 1 commit intojackwener:mainfrom
hanzili wants to merge 1 commit intojackwener:mainfrom
Conversation
eb90b71 to
3357e57
Compare
Author
|
Live-tested the patched local build against X with an actual image upload. Result verified on the profile:
The live test exposed one extra edge case: X can publish successfully while stale composer/media nodes remain visible long enough for the CLI's submission-complete heuristic to time out. I updated the PR to:
Updated local verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/compose/postroute and explicit composer/file input readiness checksTest Plan
npx vitest run --project adapter clis/twitter/post.test.js clis/twitter/reply.test.jsnpm run buildgit diff --checkBackground
While using
opencli twitter post "text" --images image.jpg, the command could report success while the resulting tweet was missing text/media. X's composer can reset the Draft.js editor while media is attaching, so the command now attaches media first and verifies the final composer state before posting.