Emacs 29 #459
Merged
Emacs 29 #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2025 21:33
In Emacs 29, the ring-insert function is not called anymore when dumb-jump-goto-file-line is called. The corresponding test relied on an implementation detail of xref-push-marker-stack. See the longer explanation in jacktasia#442. Fix the test by guarding the check for the ring-insert call with a Emacs version check.
|
Successful CI run with Emacs 29.4 is here: https://github.com/jobor/dumb-jump/actions/runs/13399588903 |
jacktasia
approved these changes
Feb 18, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the goto-file-line-test for Emacs 29 and add Emacs 29 to CI.