Skip to content

fix: incremental basebackup unit-tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackc merged 6 commits into from
Dec 13, 2025
Merged

fix: incremental basebackup unit-tests #79

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fc747b
fix: update unit-tests (skip unexpected msg instead of fail)
hashmap-kz Dec 13, 2025
fd88375
fix: run actions manually
hashmap-kz Dec 13, 2025
b8a0dbe
fix: unit-tests (condition on version)
hashmap-kz Dec 13, 2025
d0d2434
fix: unit-tests (check len of msg)
hashmap-kz Dec 13, 2025
9d6d328
fix: unit-tests, skip incremental BB is wal-summarizer is off
hashmap-kz Dec 13, 2025
529f0d9
fix: restore ci.yml for pull-req
hashmap-kz Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion pglogrepl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,12 @@ func TestBaseBackupManifest(t *testing.T) {
require.NoError(t, err)
defer closeConn(t, conn)

serverVersion, err := serverMajorVersion(conn)
require.NoError(t, err)
if serverVersion < 15 {
t.Skip("backup manifest framing via CopyData subtypes is PG15+; PG13/14 stream raw tar")
}

manifestData, filesWritten := streamBB(ctx, t, conn, false)
require.Greater(t, len(manifestData), 1)
require.GreaterOrEqual(t, len(filesWritten), 2) // manifest + base
Expand Down Expand Up @@ -445,6 +451,9 @@ func TestBaseBackupIncremental(t *testing.T) {
t.Skip()
}

// incremental requires WAL summarization
requireSummarizeWalOn(ctx, t, conn)

// create basebackup
manifestData, filesWritten := streamBB(ctx, t, conn, false)
require.Greater(t, len(manifestData), 1)
Expand Down Expand Up @@ -555,6 +564,10 @@ func streamBB(ctx context.Context, t *testing.T, conn *pgconn.PgConn, incrementa
continue

case *pgproto3.CopyData:
if len(m.Data) == 0 {
t.Logf("skip empty CopyData")
continue
}
switch m.Data[0] {
case 'n':
// New file header (tar member)
Expand Down Expand Up @@ -596,7 +609,8 @@ func streamBB(ctx context.Context, t *testing.T, conn *pgconn.PgConn, incrementa

default:
// unexpected data type – fail fast so we don't spin forever
t.Fatalf("unexpected CopyData message type: %q", m.Data[0])
t.Logf("skip unexpected CopyData subtype: %q (len=%d)", m.Data[0], len(m.Data))
continue
}

case *pgproto3.CopyDone:
Expand Down Expand Up @@ -651,3 +665,18 @@ func serverMajorVersion(conn *pgconn.PgConn) (int, error) {
}
return strconv.Atoi(verString[:dot])
}

func requireSummarizeWalOn(ctx context.Context, t *testing.T, conn *pgconn.PgConn) {
t.Helper()

rr := conn.Exec(ctx, "SHOW summarize_wal")
res, err := rr.ReadAll()
require.NoError(t, err)
require.NotEmpty(t, res)
require.Greater(t, len(res[0].Rows), 0)

val := strings.TrimSpace(string(res[0].Rows[0][0])) // first row, first column
if val != "on" {
t.Skipf("summarize_wal=%q; start postgres with -c summarize_wal=on (required for incremental base backups)", val)
}
}
Loading