Skip to content

fix CI again and some cleanup #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackc merged 3 commits into from
Mar 24, 2025
Merged

fix CI again and some cleanup #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d93ac2d
ci: switch back to compose
heavycrystal Mar 23, 2025
cd7a7f7
remove obsolete and switch to alpine
heavycrystal Mar 23, 2025
a1d90fd
remove debug Print
heavycrystal Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ jobs:
with:
go-version: ${{ matrix.go-version }}
- name: Stand up Postgres ${{ matrix.pg-version }}
run: docker compose up -d postgres:${{ matrix.pg-version }}-alpine
run: docker compose up -d postgres
env:
POSTGRES_VERSION: ${{ matrix.pg-version }}
- name: Run tests
run: go test -v -race ./...
3 changes: 1 addition & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
version: "3"
services:
postgres:
image: postgres:${POSTGRES_VERSION:-15}
image: postgres:${POSTGRES_VERSION:-17}-alpine
restart: always
command: ["-c", "wal_level=logical", "-c", "max_wal_senders=10", "-c", "max_replication_slots=10"]
environment:
Expand Down
5 changes: 2 additions & 3 deletions messageV2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package pglogrepl

import (
"fmt"
"github.com/stretchr/testify/suite"
"testing"

"github.com/stretchr/testify/suite"
)

func TestLogicalDecodingMessageV2Suite(t *testing.T) {
Expand Down Expand Up @@ -123,7 +123,6 @@ func (s *streamCommitSuite) Test() {

msg[0] = 'c'
bigEndian.PutUint32(msg[1:], xid)
fmt.Printf("%+v\n", msg)
msg[5] = flags
bigEndian.PutUint64(msg[6:], uint64(commitLSN))
bigEndian.PutUint64(msg[14:], uint64(transactionEndLSN))
Expand Down