Skip to content

Fix: fix pglogrepl.SendStandbyCopyDone #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzzzwc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: fix pglogrepl.SendStandbyCopyDone #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pglogrepl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ type CopyDoneResult struct {

// SendStandbyCopyDone sends a StandbyCopyDone to the PostgreSQL server
// to confirm ending the copy-both mode.
func SendStandbyCopyDone(_ context.Context, conn *pgconn.PgConn) (cdr *CopyDoneResult, err error) {
func SendStandbyCopyDone(_ context.Context, conn *pgconn.PgConn) (cdr CopyDoneResult, err error) {
// I am suspicious that this is wildly wrong, but I'm pretty sure the previous
// code was wildly wrong too -- wttw <steve@blighty.com>
conn.Frontend().Send(&pgproto3.CopyDone{})
Expand Down
2 changes: 1 addition & 1 deletion pglogrepl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ drop table mytable;

copyDoneResult, err := pglogrepl.SendStandbyCopyDone(ctx, conn)
require.NoError(t, err)
assert.Nil(t, copyDoneResult)
assert.Equal(t, copyDoneResult, pglogrepl.CopyDoneResult{})
}

func TestBaseBackup(t *testing.T) {
Expand Down