feat: add support for new 'tick_double' field in 'jack_position_t' (fixes #8) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes #8) Signed-off-by: Christopher Arndt <[email protected]>
falkTX
reviewed
Mar 27, 2022
| JACK_POSITION_MASK = ( | ||
| JackPositionBBT | ||
| | JackPositionTimecode | ||
| | JackBBTFrameOffset | ||
| | JackAudioVideoRatio | ||
| | JackVideoFrameOffset | ||
| | JackTickDouble |
There was a problem hiding this comment.
this doesnt match jack2 headers. JACK_POSITION_MASK in jack2 only has JackPositionBBT|JackPositionTimecode set. but that seems to be a jack2 issue.
then jack1/shared is missing the new JackTickDouble hmmm :/
not a problem for you, just noticed this inconsistency in jack headers
falkTX
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8.