Updating the bililitesRange library and fixing the selection range after rng.select#28
Open
tenbits wants to merge 2 commits into
Open
Updating the bililitesRange library and fixing the selection range after rng.select#28tenbits wants to merge 2 commits into
rng.select#28tenbits wants to merge 2 commits into
Conversation
Owner
|
Thanks for the contribution! I'll try to merge it in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jochen,
with the pull request updating here the bililiteRange library, there were some bug fixes and improvements since current version in this repository.
It also fixes the problem with the
simplecharmethod of a keysequence:rng.textmethod reapplies the text value of the element and thats why the.selectionStartis dropped to the end, though thebililiteRangetracks the bounds internal, the problem occures when triggering afterwards thekeyupevent, this makesbilliteRangeto recalculate bounds and then all further characters are appended to the end.