fix: share auto-refresh interval across consumers#37
Merged
Conversation
Each useAutoRefresh caller had its own React state seeded with the
default ('30s'); the persisted value only landed via useEffect on
mount. Toggling on one page didn't propagate to others, and every
new mount briefly armed a 30s refetch before hydrating.
Switch to a useSyncExternalStore-backed module store, mirroring
use-user.ts.
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAutoRefreshconsumers (sessions list, traces, tasks, session/trace detail) each held private React state seeded with the default'30s', hydrating from localStorage only viauseEffect. Toggling on one page didn't propagate; every new mount briefly armed a 30s refetch before correcting.useSyncExternalStore-backed module store, mirroring the existing pattern insrc/hooks/use-user.ts. Synchronous read on mount, cross-consumer notify on change, cross-tab sync viastorageevents.Test plan