Week-2 pull request#40
Open
Hungerarray wants to merge 21 commits intoitsnporg:mainfrom
Open
Conversation
setup skeletal structure for week2 challenge
added url parser using regex to find host name, scheme, and path of the url request
the required dependencies are no longer shipped with code, the instructions for setting up necessay dependencies will be added later to README.md
added functionality to create request headers
the code now will connect to http requests and do so asynchronously
was using shared_ptr to store the data, but since I didn't copy the data into handle lambda the pointer was getting destroyed as soon as it's scope ended ... leading to bad_alloc message
synchronous https request has been added, also restructured the webrequests to maintain proper interface seperation
everything has been setup and is ready for initiating the challenge
the code now truly works in parallel
linux file descriptors is the current bottleneck, which has to be fixed.
the major issue with current run is connection peer error, which has to be solved
was creating socket for every http request, don't know why I thought that to be good, now refactoring to use only few sockets instead.
most issue seems to have been fixed
cleaned up many unnecessary code lying around.
currently hits 10,000 requests 20 +- 5 seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiscordName : LuckyTiger32