Resolving W3C Validation errors caused by markup generated by appleStartup true#289
Open
joepagan wants to merge 1 commit intoitgalaxy:masterfrom
Open
Resolving W3C Validation errors caused by markup generated by appleStartup true#289joepagan wants to merge 1 commit intoitgalaxy:masterfrom
joepagan wants to merge 1 commit intoitgalaxy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
device-prefix for media attribute featuresWhy
W3C Markup Validation throws errors on the application markup generated by this where
appleStartupistrue:Markup with W3C's HTML Validator can be tested here:
https://validator.w3.org/nu/#textarea
The markup which is currently output:
The markup we want to output:
Fixes #273
Also fixes jantimon/favicons-webpack-plugin#98 further down the chain for the webpack plugin
Removing
device-prefix as suggested here:https://drafts.csswg.org/mediaqueries/#mf-deprecated
How
Done a find and replace in files to replace:
device-widthwithwidthdevice-heightwithheightFeedback
This is also replacing a bunch of references in markdown files, which appears to be used for testing purposes.
I am not too familiar with testing like that, but, running
npm run testdoes fail because the tests do not match the snapshots, please advise on how I can deal with that.