dulwich: do not add files from submodules #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Jul 31, 2025
skshetry
changed the title
Also implement `list_submodules()` to get a list of submodules in the repo, and raise `NotImplementedError` in `pygit2` for `reset()`, as libgit2 removes files from submodules on reset.
skshetry
force-pushed
the
submodules-add
branch
from
c6d7244 to
bf5688a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitdoesn't add files from submodules when staging, so we aligndulwichwith that behavior.Also,
libgit2/pygit2removes files from submodules onreset(), so raiseNotImplementedErrorfor now to avoid accidental deletions, and redirect such cases to theGitPythonbackend instead.Fixes iterative/dvc#10823.