Skip to content

Update Benchmark README.md to reflect actual options in runner.py #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

npankaj365
Copy link
Contributor

Updates example command lines in README.md to use no_istio instead of baseline to match runner.py's implemented arguments

This commit updates the README.md to replace `baseline` with `no_istio` in the Example codes for `runner.py` to reflect the implemented arguments from `runner.py`.
@npankaj365 npankaj365 requested a review from a team as a code owner January 15, 2025 16:39
@istio-policy-bot
Copy link

😊 Welcome @npankaj365! This is either your first contribution to the Istio tools repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

Copy link

linux-foundation-easycla bot commented Jan 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: npankaj365 / name: Pankaj Niroula (14d0c65)

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2025
@istio-testing
Copy link
Contributor

Hi @npankaj365. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhawton dhawton added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 10, 2025
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jun 10, 2025
@dhawton dhawton reopened this Jun 10, 2025
@dhawton dhawton removed the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jun 10, 2025
@istio-testing istio-testing merged commit 0cdda23 into istio:master Jun 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants