Skip to content

fix npm warnings #16579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AritraDey-Dev
Copy link
Member

Description

This PR resolves npm warnings caused by deprecated [email protected] and [email protected] by overriding them.
few observations:

Before

$ npm explain inflight glob
[email protected]
node_modules/inflight
  inflight@"^1.0.4" from [email protected]
  node_modules/glob
    glob@"^7.2.0" from @babel/[email protected]
    node_modules/@babel/cli
      @babel/cli@"^7.23.0" from the root project
    glob@"^7.2.0" from [email protected]
    node_modules/svgstore-cli
      svgstore-cli@"^2.0.1" from the root project

[email protected]
node_modules/glob
  glob@"^7.2.0" from @babel/[email protected]
  node_modules/@babel/cli
    @babel/cli@"^7.23.0" from the root project
  glob@"^7.2.0" from [email protected]
  node_modules/svgstore-cli
    svgstore-cli@"^2.0.1" from the root project

Now (After the fix)

$  npm explain inflight glob
[email protected]
node_modules/glob
 overridden glob@"^10.0.0" (was "^7.2.0") from @babel/[email protected]
 node_modules/@babel/cli
   @babel/cli@"^7.27.2" from the root project
 overridden glob@"^10.0.0" (was "^7.2.0") from [email protected]
 node_modules/svgstore-cli
   svgstore-cli@"^2.0.1" from the root project

Fixes #16573

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Fixes istio#16573

Signed-off-by: Aritra Dey <[email protected]>
@AritraDey-Dev AritraDey-Dev requested a review from a team as a code owner June 13, 2025 12:18
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2025
@AritraDey-Dev AritraDey-Dev changed the title chore: fix npm warnings fix npm warnings Jun 13, 2025
@dhawton
Copy link
Member

dhawton commented Jun 13, 2025

Why not place the override directly in packages.json? I don't like having things be different in tests vs deployment.. they should be the same.

@AritraDey-Dev
Copy link
Member Author

Why not place the override directly in packages.json? I don't like having things be different in tests vs deployment.. they should be the same.

Yes, my first thought was to do that in package.json itself. But there is no package.json in the project — it is created by the Makefile.core.mk here

@npm init -y

So if we need to make changes to package.json, we first need to create it and then apply the override.

@dhawton
Copy link
Member

dhawton commented Jun 13, 2025

Might be worth changing... I don't like the thought of having production be different from dev. I'll defer to @craigbox here though as there are a number of plans he has for docs that I am not in the loop on.

@AritraDey-Dev
Copy link
Member Author

yes i agree it’s better to have a consistent package.json checked into the project so it don’t have differences between dev and prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix npm warnings in site build
4 participants