Skip to content

Conversation

@libesz
Copy link
Contributor

@libesz libesz commented May 22, 2025

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

My dev machine contains several shell plugins, like FZF. That plugin has env var settings, where one of them has multiline value. env command represents multiline values in a way that they are actually split into multiple lines, which makes parsing the command output hard. When sail-operator make targets are consuming the env command output, they can fail when multiline env vars are present. That is, I assume we never need multiline variable values for real, so we can unset them to resolve the issue.

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

@istio-testing
Copy link
Collaborator

Hi @libesz. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (3037eff) to head (0a41d72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   76.47%   76.32%   -0.16%     
==========================================
  Files          44       44              
  Lines        2640     2640              
==========================================
- Hits         2019     2015       -4     
- Misses        533      536       +3     
- Partials       88       89       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dgn
Copy link
Collaborator

dgn commented May 23, 2025

Thanks @libesz! We pull the code for everything under common/ from https://github.com/istio/common-files, so this change should go into https://github.com/istio/common-files/blob/master/files/common/scripts/setup_env.sh

@libesz
Copy link
Contributor Author

libesz commented May 26, 2025

Thanks @dgn . There it is: istio/common-files#1185

@libesz libesz closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants