-
Notifications
You must be signed in to change notification settings - Fork 15
Support for Leaflet 1.0.1 and added Typescript-Definition #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Schwobaland
wants to merge
13
commits into
ismyrnow:gh-pages
Choose a base branch
from
Schwobaland:master
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e3d5ae0
add typescript
343c5bc
support for leaflet 1.0
1716c15
add gitignore
14b13f4
correct error in typescript definition
d223834
adding index.d.ts
8e44745
remove index.ts and add types-property to package.json
dde21bc
exampes changes
c4f0a9b
Reaadme changed
28f9f26
remove typescript stuff
f8d6986
fix indentation
794d16f
fix indentation
9da47c1
removed tsconfig
bff707d
Merge branch 'gh-pages' of https://github.com/ismyrnow/Leaflet.functi…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| node_modules | ||
| .DS_Store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,27 @@ | ||
| Leaflet.functionaltilelayer | ||
| =========================== | ||
|
|
||
| For use with Leaflet 1.0.1. | ||
|
|
||
| Leaflet tile layer with functionally defined URL and support for promises. | ||
|
|
||
| A typical use case is fetching tiles asynchronously, with an ajax request or | ||
| IndexedDB query. | ||
|
|
||
| ## Usage | ||
| Use it like any other tile layer, but instead of providing a `urlTemplate` as | ||
| the first argument, provide a function. The function should return either the | ||
|
|
||
| Use it like any other tile layer, but instead of providing a `urlTemplate` as | ||
| the first argument, provide a function. The function should return either the | ||
| tile URL as a string, or a promise which resolves to a string. | ||
|
|
||
| ```javascript | ||
| var funcLayer = new L.TileLayer.Functional(function (view) { | ||
| var url = 'http://otile{3}.mqcdn.com/tiles/1.0.0/map/{0}/{1}/{2}.jpg' | ||
| .replace('{0}', view.zoom) | ||
| .replace('{1}', view.tile.row) | ||
| .replace('{2}', view.tile.column) | ||
| .replace('{3}', view.subdomain); | ||
| var url = 'http://{s}.tile.osm.org/{z}/{x}/{y}.png' | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for bringing in valid tiles (since the mq tiles went away)! |
||
| .replace('{z}', view.zoom) | ||
| .replace('{y}', view.tile.row) | ||
| .replace('{x}', view.tile.column) | ||
| .replace('{s}', view.subdomain); | ||
|
|
||
| return url; | ||
| }); | ||
| ``` | ||
|
|
@@ -40,10 +43,10 @@ view = { | |
| ``` | ||
|
|
||
| For an example of the code above, see the [basic example] | ||
| (http://ismyrnow.github.com/Leaflet.functionaltilelayer/example/basic.html). | ||
| (example/basic.html). | ||
|
|
||
| For an example of using promises, see the [promise example] | ||
| (http://ismyrnow.github.com/Leaflet.functionaltilelayer/example/promise.html). | ||
| (example/promise.html). | ||
|
|
||
| ## Thanks | ||
|
|
||
|
|
@@ -53,4 +56,4 @@ which were the inspiration for this plugin. | |
| ## License | ||
|
|
||
| Leaflet.functionaltilelayer is free software, and may be redistributed under | ||
| the MIT-LICENSE. | ||
| the MIT-LICENSE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might tweak this a bit, to note that an older version is available. You can leave it how it is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a version number 1.0.0 to package.json. Maybe you could create a tag for 0.7.