Effects don't work on note pages of PDFs

[isaacwisdom]

Describe the bug
So it turns out that note pages of pdfs include the text tool, but still report as being "fileType: PDF", meaning my tool has no way of knowing wether the currently open page of a pdf document is a pdf and has the text tool, or is a note page and does not.

To Reproduce
Steps to reproduce the behavior:

1. open PDF
2. add note page
3. try actions, observe unexpected behavior

Expected behavior
Actions should behave as expected.

reMarkable Info (please complete the following information):

• reMarkable Version (eg. 1 or 2): 2
• OS version (In Settings > General > Software): 3.x.x.x
• Branch (eg. v1, v2, v2-3.0.0-fix): v2-3.0.0-fix
• Document Type (eg. PDF, Notebook): PDF
• Document Orientation: (eg. RH or LH, Portrait or Landscape): RHP

Please include your config file (for example, by running cat /home/root/.config/LamyEraser/LamyEraser.conf) here:
N/A

Additional context
N/A

[rachentp]

Describe the bug

The result is the same from #58.

Steps:

• un/reinstalled just now
• opened PDF
• added a note page
• tried the actions, specifically undo, eraser-selection and select.

reMarkable Info

• rM 2
• 3.4.1.1790
• v2-3.0.0-fix
• PDF type and Notebook
• RHP
• cat /home/root/.config/LamyEraser/LamyEraser.conf

# RemarkableLamyEraser Configuration File~
click
double-click                undo
triple-click
quadruple-click
quintuple-click

press&hold                  eraser-selection
double-press&hold           select
triple-press&hold
quadruple-press&hold
quintuple-press&hold

[isaacwisdom]

I have a bit of an odd request. Can you

1. Uninstall and reinstall from the v2-3.0.0-fix branch
2. Open a notebook in Right Hand, portrait orientation
3. draw a line
4. try to undo that line by double clicking.

If it works great! If not, can you then:
5. Without touching the screen, try to undo by double clicking again. This is a little tricky because the tip of the pen needs to be hovering above the screen for the tablet to detect the button clicks, but there should be no direct contact with the tablet.

Let me know what you experience.
Thanks!

[rachentp]

You do great work, so no request is odd :)

Steps

1. Un/reinstalled from v2-3.0.0-fix branch
2. Opened a new notebook in RHP
3. Drew a horizontal line
4. Double clicked.

Result was the same as before, nothing happened.

5. Then, without touching anything and the pen tip like maybe 1 cm away from the tablet surface, I double clicked again. Still, nothing happened.

I know the quirk you're talking about, I figured it out before with v1. I know there's a very small and specific window where the pen tip needs to hover over the screen and not detect any other interaction (like palm touches, etc.).

Then I tried all steps again (except for un/reinstall) in terminal and I get this output:

RemarkableLamyEraser 2.1.0
----------------------------------
Detected ReMarkable 2, Software Version: 3.x.x.x
Using Devices:
1. device file = /dev/input/event1
   device name = Wacom I2C Digitizer
2. device file = /dev/input/event2
   device name = pt_mt
----------------------------------
Using configuration file at /home/root/.config/LamyEraser/LamyEraser.conf
Line 30: Read trigger <double-click> with effect <undo>
Line 35: Read trigger <press&hold> with effect <eraser-erase>
Line 36: Read trigger <double-press&hold> with effect <select>
----------------------------------
writing undo
writing undo
writing undo
writing eraser
Activating ToolEraserRM2: writing eraser on
writing eraser
Deactivating ToolEraserRM2: writing pen on
writing eraser
Activating ToolEraserRM2: writing eraser on
writing eraser
Deactivating ToolEraserRM2: writing pen on

But again, nothing works except for eraser-erase. Let me know if there's anything else I can do!