testing findAllByNameAndDepartment with only one parameter#151
Open
RamonJales wants to merge 1 commit into
Open
testing findAllByNameAndDepartment with only one parameter#151RamonJales wants to merge 1 commit into
RamonJales wants to merge 1 commit into
Conversation
Kywal
requested changes
Jan 12, 2024
Collaborator
Kywal
left a comment
Kywal
left a comment
There was a problem hiding this comment.
Acho que precisa do contains nesse caso. Podem haver outras disciplinas no banco que satisfaçam o filtro, o que dá espaço para que o teste resulte em um falso positivo/negativo.
isaacmsl
requested changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Por favor, informe se a PR segue os requisitos obrigatórios:
Motivação para a criação da PR
Adicionar um teste com string vazia no método
findAllByNameContainingIgnoreCaseAndDepartmentContainingIgnoreCase.