feat: Cisco NXOS vPCs #96
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
7a146d3 to
57755c4
Compare
hardikdr
added
the
area/metal-automation
nikatza
force-pushed
the
cisco-nxos-vpc
branch
2 times, most recently
from
0b789b3 to
52078ca
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
52078ca to
b960688
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
11 times, most recently
from
218ebd5 to
2f2cd99
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
10 times, most recently
from
f6fb13c to
b3fd3db
Compare
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
b3fd3db to
5fede6d
Compare
Multi-Chassis Link Aggregation (MC-LAG) is quite vendor and platform specific. We don't see much intersection in their respective configuration to justify a common API type. Instead, we move forward with a platform specific API exclusive to Cisco NXOS devices. This commit adds new types, controller, and provider to configure virtual Port Channels (vPCs) via the operator. Implementation note: Consider the following information about the YANG model for configuring a vPC: * each vPC configured in the domain appears in the tree in this location: `vpc-items/inst-items/dom-items/if-items/If-list[id=30]` (where `30` is the vPC ID) * the peer-link interface is configured here: `vpc-items/inst-items/dom-items/keepalive-items/peerlink-items[id=po10]` The interfaces will be added to the vPC config by the LAG provider and not by this controller. Hence, if we apply a gNMI Replace operation on the xpath returned by VPC.XPath() we would remove any existing vPC interfaces. A gNMI Update operation will not modify the configuration introduced by the LAG provider.
nikatza
force-pushed
the
cisco-nxos-vpc
branch
from
5fede6d to
833c5c3
Compare
Merging this branch changes the coverage (3 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-Chassis Link Aggregation (MC-LAG) is quite vendor and platform
specific. We don't see much intersection in their respective
configuration to justify a common API type. Instead, we move forward
with a platform specific API exclusive to Cisco NXOS devices.
This commit adds new types, controller, and provider to configure
virtual Port Channels (vPCs) via the operator.
Implementation note: Consider the following information about the YANG
model for configuring a vPC:
location:
vpc-items/inst-items/dom-items/if-items/If-list[id=30](where
30is the vPC ID, not to be confused with the domain ID)vpc-items/inst-items/dom-items/keepalive-items/peerlink-items[id=po10]The interfaces will be added to the vPC config by the LAG provider and
not by this controller. Hence, if we apply a gNMI Replace operation on
the xpath returned by VPC.XPath() we would remove any existing vPC
interfaces. A gNMI Update operation will not modify the configuration
introduced by the LAG provider.