Fix gnmiext list unmarshaling and skipped updates
#125
+31
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
4a1adf9 to
a638523
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
3cda665 to
fd620b6
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
a638523 to
c7dc3ad
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
fd620b6 to
a2831e5
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
c7dc3ad to
1875e7f
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
a2831e5 to
26458fd
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
1875e7f to
32859e5
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
26458fd to
63b6597
Compare
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
32859e5 to
d2b1137
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
63b6597 to
2ecdcc4
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
d2b1137 to
b8b7057
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
2ecdcc4 to
19cc3ca
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
b8b7057 to
2a761eb
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
19cc3ca to
ddaba13
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
2a761eb to
f629ce1
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
ddaba13 to
3ba2a3a
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
f629ce1 to
b38cfc6
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
3ba2a3a to
f1db2f3
Compare
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
b38cfc6 to
1157056
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
f1db2f3 to
eaeaf03
Compare
When fields are absent in the YANG payload, they are skipped when the payload is unmarshaled into a Go struct. This lead to invalid comparisons, as the `gnmiext.Client` failed to detect changes in this case. This commit fixes this issue, by resetting struct fields not present in the YANG payload with a json struct tag back to their zero value.
felix-kaestner
force-pushed
the
irb-anycast-gateway
branch
from
1157056 to
6dc799b
Compare
felix-kaestner
force-pushed
the
gnmiext-fixes
branch
from
eaeaf03 to
810522f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.