read SEL from bmc to set server health condition #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuckal777
requested changes
Oct 24, 2025
Comment on lines
+348
to
+362
| for _, logEntry := range logs { | ||
| serverBase := server.DeepCopy() | ||
| if err := acc.UpdateSlice( | ||
| &server.Status.Conditions, | ||
| ServerHealthyConditionType, | ||
| conditionutils.UpdateStatus(corev1.ConditionFalse), | ||
| conditionutils.UpdateReason(logEntry.Name), | ||
| conditionutils.UpdateMessage(logEntry.Message), | ||
| ); err != nil { | ||
| return fmt.Errorf("failed to patch condition %s: %w", corev1.ConditionFalse, err) | ||
| } | ||
| if err := r.Status().Patch(ctx, server, client.MergeFrom(serverBase)); err != nil { | ||
| return fmt.Errorf("failed to patch BMC conditions: %w", err) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This loop only stores the last entry in the conditions slice, as it is overwriting any previous reasons and messages. I think the logs should be concatenated into a single message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reads the critical SEL (system event logs) from a BMC to update the server health condition.
open points: