Added Topology labels #1418
Merged
Added Topology labels #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the possibility to set topology labels on the machine pools. The labels have to be provided as arguments to the `/machinepoollet` command. They are initially set when the `MachinePool` is created. The reconceiler ensures they are reset in case they have been changed.
balpert89
reviewed
Nov 24, 2025
github-actions
bot
added
the
documentation
Don't check for changes, but simply apply the patch, accepting a potentially empty patch call.
lukasfrank
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds the possibility to set topology labels on the machine, volume and bucket pools.
The labels have to be provided as arguments to the
/<x>poolletcommand. The arguments are only considered if a non empty value is provided.They are initially set when the
<x>Poolis created. The reconciler ensures that they are reset in case they have been changed and only then.Fixes #1411