[744] Add mypy type checking #753
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example output of this job is available in the fork at https://github.com/stsnel/python-irodsclient/actions/runs/16191658560/job/45708614323 |
korydraughn
reviewed
Jul 1, 2025
stsnel
force-pushed
the
add-mypy-type-checking
branch
9 times, most recently
from
1f41318 to
580a5c6
Compare
alanking
reviewed
Jul 14, 2025
stsnel
force-pushed
the
add-mypy-type-checking
branch
2 times, most recently
from
4caffdd to
0e9b58a
Compare
alanking
reviewed
Aug 5, 2025
There was a problem hiding this comment.
New changes seem good to me. Let's give @d-w-moore a chance to have a look, and then I think we can get this in. Thanks
korydraughn
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Code changes look good.
We'll give @d-w-moore a chance to look over the changes to see if anything stands out to him. Once he approves, we can move forward with getting this in.
stsnel
force-pushed
the
add-mypy-type-checking
branch
2 times, most recently
from
682d0cb to
103f05d
Compare
stsnel
force-pushed
the
add-mypy-type-checking
branch
from
103f05d to
1a78387
Compare
Hope to look them over today... latest, monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is ready for review