Skip to content

Cleanup / fix delegated routing response headers#241

Merged
byo merged 3 commits into
mainfrom
cleanup-delegated-routing-response-headers
May 25, 2026
Merged

Cleanup / fix delegated routing response headers#241
byo merged 3 commits into
mainfrom
cleanup-delegated-routing-response-headers

Conversation

@byo
Copy link
Copy Markdown
Contributor

@byo byo commented May 7, 2026

  • Always send X-Content-Type-Options: nosniff to prevent detection of content type
  • Add Vary: Accept to inform clients that the response depends on the Accept header
  • Fix Allow header when invalid method was used
  • Always send 404 Not found with text/plain content type
  • Always send the Cache-control: public header

@byo byo requested review from gammazero and willscott May 7, 2026 16:08
byo added 2 commits May 7, 2026 18:12
* Always send `X-Content-Type-Options: nosniff`
  to prevent detection of content type
* Add `Vary: Accept` to inform clients that the response
  depends on the Accept header
* Fix `Allow` header when invalid method was used
* Always send 404 Not found with `text/plain` content type
* Always send the `Cache-control: public` header
@byo byo force-pushed the cleanup-delegated-routing-response-headers branch from 37b7302 to 12a1396 Compare May 7, 2026 16:13
Copy link
Copy Markdown

@nymd nymd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth addressing? but not a blocker

Comment thread delegated_translator.go
@nymd nymd assigned byo May 7, 2026
@byo byo force-pushed the cleanup-delegated-routing-response-headers branch from 6253459 to f160371 Compare May 25, 2026 10:46
@byo byo merged commit 68e9e1d into main May 25, 2026
6 checks passed
@byo byo deleted the cleanup-delegated-routing-response-headers branch May 25, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants