Skip to content

Removed unused and possibly ambiguous log levels #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netromdk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed unused and possibly ambiguous log levels #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ int main()
});

// enables all log
app.loglevel(crow::LogLevel::DEBUG);
app.loglevel(crow::LogLevel::Debug);
//crow::logger::setHandler(std::make_shared<ExampleLogHandler>());

app.port(18080)
Expand Down
2 changes: 1 addition & 1 deletion examples/example_vs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ int main()
});

// ignore all log
crow::logger::setLogLevel(crow::LogLevel::DEBUG);
crow::logger::setLogLevel(crow::LogLevel::Debug);
//crow::logger::setHandler(std::make_shared<ExampleLogHandler>());

app.port(18080)
Expand Down
8 changes: 0 additions & 8 deletions include/crow/logging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@ namespace crow
{
enum class LogLevel
{
#ifndef ERROR
DEBUG = 0,
INFO,
WARNING,
ERROR,
CRITICAL,
#endif

Debug = 0,
Info,
Warning,
Expand Down