folly/tracing: Add ARM and AArch64 support to static tracepoints#5491
Open
hsadinen wants to merge 2 commits intoiovisor:masterfrom
Open
folly/tracing: Add ARM and AArch64 support to static tracepoints#5491hsadinen wants to merge 2 commits intoiovisor:masterfrom
hsadinen wants to merge 2 commits intoiovisor:masterfrom
Conversation
hsadinen
requested review from
brendangregg,
chenhengqi,
ekyooo and
yonghong-song
as code owners
Collaborator
|
Could you add an appropriate prefix to the commit message? (ex. test/python: xxx) |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Mar 16, 2026
This resolves USDT probe test failures on ARM64 platforms. Without these changes, the .note.stapsdt section containing probe information was missing entirely on ARM64, causing test failures when attempting to find and attach to USDT probes in the BCC test suite. Upstream-Status: Submitted [iovisor/bcc#5491] Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Mar 17, 2026
This resolves USDT probe test failures on ARM64 platforms. Without these changes, the .note.stapsdt section containing probe information was missing entirely on ARM64, causing test failures when attempting to find and attach to USDT probes in the BCC test suite. Upstream-Status: Submitted [iovisor/bcc#5491] Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Rename StaticTracepoint-ELFx86.h to StaticTracepoint-ELF.h so the header name is no longer tied to a specific architecture, enabling future support for additional architectures. Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
Extend the static tracepoint (SDT) macros to work on ARM and AArch64 by: - Defining FOLLY_SDT_NOP as "nop" (the same mnemonic works for both ARM and AArch64) - Adding `defined(__aarch64__) || defined(__arm__)` to the preprocessor guard in StaticTracepoint.h This resolves USDT probe test failures on ARM64 platforms. Without these changes, the .note.stapsdt section containing probe information was missing entirely on ARM64, causing test failures when attempting to find and attach to USDT probes in the BCC test suite. Fixes: iovisor#5354 Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
Contributor
Author
|
@ekyooo, I have updated commit message with appropriate prefix. |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Mar 17, 2026
This resolves USDT probe test failures on ARM64 platforms. Without these changes, the .note.stapsdt section containing probe information was missing entirely on ARM64, causing test failures when attempting to find and attach to USDT probes in the BCC test suite. Upstream-Status: Submitted [iovisor/bcc#5491] Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves USDT probe test failures on ARM64 platforms.
Without these changes, the .note.stapsdt section containing probe
information was missing entirely on ARM64, causing test failures when
attempting to find and attach to USDT probes in the BCC test suite.
Fixes: #5354