libbpf-tools: trace_helpers: add str_loadavg() #5344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rtoax
requested review from
4ast,
brendangregg,
davemarchevsky,
drzaeus77,
goldshtn and
yonghong-song
as code owners
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
from
e60b55d to
c8b7b1b
Compare
ekyooo
reviewed
Jul 4, 2025
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
3 times, most recently
from
2585756 to
25adc38
Compare
Contributor
Author
|
@ekyooo Thanks for all the advise, and also thanks @yonghong-song , please review. |
ekyooo
reviewed
Jul 6, 2025
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
from
25adc38 to
17daa2d
Compare
Contributor
Author
|
@ekyooo add |
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
2 times, most recently
from
df70840 to
9a0478f
Compare
Contributor
Author
|
rebase to master. |
ekyooo
reviewed
Jul 8, 2025
chenhengqi
reviewed
Jul 8, 2025
Collaborator
chenhengqi
left a comment
chenhengqi
left a comment
There was a problem hiding this comment.
Nice cleanup. Thanks.
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
2 times, most recently
from
a8cd50e to
7e96308
Compare
ekyooo
reviewed
Jul 10, 2025
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
from
7e96308 to
757c55d
Compare
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
2 times, most recently
from
dce4049 to
bc1d4a8
Compare
Contributor
Author
|
Rebase to master. |
ekyooo
reviewed
Jul 16, 2025
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
from
bc1d4a8 to
3ac7914
Compare
ekyooo
reviewed
Jul 17, 2025
Collaborator
ekyooo
left a comment
ekyooo
left a comment
There was a problem hiding this comment.
From my viewpoint, we’re nearly done.
I appreciate your patience with my iterative requests.
Thanks!
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
from
3ac7914 to
0260e09
Compare
There are many tools read /proc/loadavg and timestamp, this commit add two common function str_loadavg() and str_timestamp(). And fix bashreadline timestamp's wrong format, %m is month, should be %M (min). Signed-off-by: Rong Tao <[email protected]>
Rtoax
force-pushed
the
patch-100-libbpf-str_loadavg
branch
from
0260e09 to
153b9d7
Compare
Contributor
Author
Totally OK, more patience, higher quality. thanks. |
Collaborator
|
LGTM. Thanks for nice cleanup. |
ekyooo
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many tools read /proc/loadavg, this commit add a comment function str_loadavg().