This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Draft
Conversation
TIP-47: Storage Deposit
…on for rewards endpoint.
thibault-martinez
suggested changes
Jan 10, 2024
Member
thibault-martinez
left a comment
thibault-martinez
left a comment
There was a problem hiding this comment.
There are errors when opening the Core Swagger
* staker: registered validator * validator: committee member
| strongParents: | ||
| - "0x0482f0eba39a23c9a13072c93d828b55543132c47f5f57514d9e55535e9d4f4f35000000" | ||
| - "0xae7c4f55a6db8bf4841e4a38f06d32ab9bd88b927a6ba0bc19bcb19c625ff8b63c000000" | ||
| weakParents: |
Member
There was a problem hiding this comment.
These are not ordered
| blockState: | ||
| type: string | ||
| enum: | ||
| - pending |
Thoralf-M
reviewed
Feb 15, 2024
Alex6323
reviewed
Feb 28, 2024
Comment on lines
+3474
to
+3485
| BlockFullResponse: | ||
| description: Returns the block structure and the metadata of a given block. | ||
| properties: | ||
| block: | ||
| $ref: '#/components/schemas/Block' | ||
| description: The requested block structure. | ||
| metadata: | ||
| $ref: '#/components/schemas/BlockMetadataResponse' | ||
| description: The metadata of the requested block. | ||
| required: | ||
| - block | ||
| - metadata |
There was a problem hiding this comment.
Can this be renamed to BlockWithMetadataResponse? Would be consistent with OutputWithMetadataResponse.
| metrics: | ||
| blocksPerSecond: "1.1E+00" | ||
| confirmedBlocksPerSecond: "2.2E+00" | ||
| confirmationRate: "3.3E+00" |
Member
There was a problem hiding this comment.
Do we really want scientific notation?
| - latestAcceptedBlockSlot | ||
| - latestConfirmedBlockSlot | ||
| - pruningEpoch | ||
| metrics: |
Member
There was a problem hiding this comment.
Needs to be put into its own route + response
| - block | ||
| - metadata | ||
|
|
||
| BlockMetadataResponse: |
Member
There was a problem hiding this comment.
Needs to be updated to latest (and examples)
| - blockId | ||
| - blockState | ||
|
|
||
| TransactionMetadataResponse: |
Member
There was a problem hiding this comment.
Needs to be updated to latest (and examples)
Thoralf-M
reviewed
Mar 13, 2024
| description: Return the information of committee members at the given epoch index. If epoch index is not provided, the current committee members are returned. | ||
| parameters: | ||
| - in: query | ||
| name: epochIndex |
Member
There was a problem hiding this comment.
Suggested change
| name: epochIndex | |
| name: epoch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swagger Previews:
Note that this TIP is in Draft mode and as such is still being updated.