feat(dapp): hide buy name option if auction #858
+18
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarcev
requested changes
Nov 11, 2025
| priceSupportingText={isAvailable ? 'Price' : undefined} | ||
| statusMessage={isAvailable ? undefined : 'Name cannot be purchased.'} | ||
| > | ||
| {isUnavailable ? null : isConnected ? ( |
Collaborator
There was a problem hiding this comment.
If isAvailable it won't ever be isUnavailable
marc2332
requested changes
Nov 13, 2025
Comment on lines
387
to
390
| isAvailable={isAvailable} | ||
| price={formattedPurchasePrice} | ||
| priceSupportingText={isAvailable ? 'Price' : undefined} | ||
| statusMessage={isAvailable ? undefined : 'Name cannot be purchased.'} |
Contributor
There was a problem hiding this comment.
Right?
Suggested change
| isAvailable={isAvailable} | |
| price={formattedPurchasePrice} | |
| priceSupportingText={isAvailable ? 'Price' : undefined} | |
| statusMessage={isAvailable ? undefined : 'Name cannot be purchased.'} | |
| isAvailable={true} | |
| price={formattedPurchasePrice} | |
| priceSupportingText="Price" |
|
This pull request has been deployed to Vercel.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #819