Integrate product-core branch feat/iota-v1-2-3-and-resources-for-wasm
#1687
+504
−597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e branch chore/pin-iota-dependency-to-v1-2-3
chrisgitiota
added
Wasm
…nteraction-ts@alpha equivalent to "^0.6.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR integrates the latest
product-coresources from product-core branchfeat/iota-v1-2-3-and-resources-for-wasmintoIOTA Identity.This PR is needed to comment & discuss proposed identity-repository-code-changes needed to integrate the latest product-core.
After the
product-corePR #38: Pin iota dependency to v1.2.3 and gather resources for Notarization wasm bindings has been merged toproduct-core mainand a new version-tag + npmjs-package has been released, this PR can also be used to run CI tests for the latestproduct-corecode.Links to any relevant issues
Fixes #1677
This PR can be seen as QA for the product-core release that is needed to fix the notarization tickets:
Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
Currently this PR can only be build when the
product-corebranchfeat/iota-v1-2-3-and-resources-for-wasmis checked out in a neighboring folder (namedproduct-core). This is needed to build the latest version of the@iota/iota-interaction-tspackage which is not available on npmjs.com and finally to build the@iota/identity-wasmnpmjs package.How to build the
@iota/identity-wasmnpmjs package with localproduct-core?After having checked out the
product-corebranchfeat/iota-v1-2-3-and-resources-for-wasmas described above in a neighbored folder, you can build the@iota/identity-wasmnpm project like this:In the neighbored
product-corefolder where branchfeat/iota-v1-2-3-and-resources-for-wasmhas been checked out:cd bindings/wasm/iota_interaction_ts npm install npm run build:nodejsIn the root folder of the
identity_wasmproject:cd bindings/wasm/identity_wasm npm install npm run build:nodejs