fix: improve member signature type parsing for tuples and curried types#173
Draft
alexdarch wants to merge 1 commit intoionide:mainfrom
Draft
fix: improve member signature type parsing for tuples and curried types#173alexdarch wants to merge 1 commit intoionide:mainfrom
alexdarch wants to merge 1 commit intoionide:mainfrom
Conversation
Add _argument_type and _curried_return_type type subsets to correctly parse member signatures. Before this fix, `string -> string * string` in a member signature would incorrectly parse `*` as part of a tuple argument type rather than a tuple return type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argument_spec so that * and -> in argument position are parsed as separate positional
arguments rather than tuple/function types
-> is consumed by the argument repeat rather than parsed as a function return type
Before this fix
abstract member Query : string -> string * string would incorrectly parse string *
string as a tuple-typed argument rather than a tuple return type.