feat: Add wildcard slice expression support#151
Open
NatElkins wants to merge 1 commit intoionide:mainfrom
Open
feat: Add wildcard slice expression support#151NatElkins wants to merge 1 commit intoionide:mainfrom
NatElkins wants to merge 1 commit intoionide:mainfrom
Conversation
Implements wildcard slice syntax for arrays and lists: - arr.[*] selects all elements - matrix.[0.., *] for multi-dimensional slicing - Consistent with F# 6.0+ slice syntax The grammar already supported '*' in slice_range but wasn't creating a proper AST node. This change aliases '*' as wildcard_slice for clearer AST representation. Tests added for: - Simple wildcard slice: arr.[*] - 2D array row slice: matrix.[0.., *] - 2D array column slice: matrix.[*, 0..]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for wildcard slice expressions (
[*]) in F# arrays and lists, improving AST clarity for this common slicing pattern.Problem
The grammar already parsed
arr.[*]syntax but didn't create a proper AST node for the wildcard, making it difficult for tools to recognize this as a distinct operation from other slice patterns.Solution
Added an alias for
"*"aswildcard_slicein theslice_rangerule:Examples
The following F# code now produces clear AST nodes:
Tests
Added 3 tests to
test/corpus/expr.txt:All existing tests continue to pass.
Related
This addresses one of the gaps identified in #150 (Implementation Status tracking).