Remove error recovery handling in scanner.h causing parser to get stuck | fix #134

[LhKipp]

No description provided.

[Nsidorenco]

Hi @LhKipp,

Thank you for helping make the grammar more stable! It appears the recent update to tree-sitter broke the CI so I have reverted the update.
Could you please rebase this PR onto main and re-generate the grammar?

[LhKipp]

Could you please rebase this PR onto main and re-generate the grammar?

Sure. The change set looks much better now :)

[Nsidorenco]

Hi @LhKipp,
Sorry for taking so long getting to this!

I'm wondering if there would be another way to handle the looping in this case, where we could change the production rules instead?
The reason for the error recovery code is to enable better parsing of partial statements, e. g:

match x with
|

would still be able to parse as a match statement even though it is not a syntactically correct match statement.
If we flat out remove the error recovery we would negatively impact the grammar in other areas.

[LhKipp]

Hi @Nsidorenco,

Sorry for taking so long getting to this!

No worries. It didn't felt long to me :)

I'm wondering if there would be another way to handle the looping in this case, where we could change the production rules instead?

There maybe is. I am sorry to tell you, that I neither have the tree-sitter knowledge to know the solution, nor that I want to spend my time and energy on this problem (now). If you feel like this PR is a regression overall, feel free to close it or move it into draft. I won't be offended.

For me this change made the grammar usable. I am using Neovim, which apparently runs the tree-sitter parsing on the main-loop (and not async), so if the grammar runs into an endless loop, so does the editor and feels "frozen". I understand other editors can behave differently and then it's not so much of an annoyance.